crypto: doc-deprecate multiple Hmac.digest() calls (DEP0206)#63121
Open
Anshikakalpana wants to merge 1 commit intonodejs:mainfrom
Open
crypto: doc-deprecate multiple Hmac.digest() calls (DEP0206)#63121Anshikakalpana wants to merge 1 commit intonodejs:mainfrom
Anshikakalpana wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
Member
|
We should create a doc-deprecation first that can land on current release lines. |
Author
|
@Renegade334 |
Renegade334
reviewed
May 4, 2026
Member
|
Please can you squash your commits with a new commit message that reflects a documentation-only deprecation, so that the changelog is correct? |
Renegade334
reviewed
May 4, 2026
Anshikakalpana
force-pushed
the
hmac-fix-v2
branch
from
e325215 to
e79e916
Compare
Author
|
Thanks! Updated and squashed into a single doc-only commit. |
Renegade334
reviewed
May 4, 2026
| description: Documentation-only deprecation. | ||
| --> | ||
|
|
||
| Type: Runtime |
Member
There was a problem hiding this comment.
Suggested change
| Type: Runtime | |
| Type: Documentation-only |
LGTM otherwise. I suspect you will need to shorten your commit message though.
Anshikakalpana
force-pushed
the
hmac-fix-v2
branch
from
e79e916 to
6777eeb
Compare
Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>
Anshikakalpana
force-pushed
the
hmac-fix-v2
branch
from
6777eeb to
2646e50
Compare
Renegade334
approved these changes
May 5, 2026
Renegade334
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #62838
Situation
Calling
digest()on an already-finalizedHmacinstance currently returns an empty buffer silently instead of throwing an error. This is inconsistent withHashbehavior which throwsERR_CRYPTO_HASH_FINALIZEDand is a potential security footgun.Change
Add a runtime deprecation warning (DEP0206) when
digest()is called more than once on anHmacinstance. The existing behavior (returning an empty buffer) is preserved during the deprecation cycle to avoid breaking changes.